Fixes for ECAL rechits on GPU #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compilation warnings, remove commented out code, and apply code formatting rules.
…ack with cms-merge-topic
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Validation summaryReference release CMSSW_11_1_0_pre8 at 442ae07 Validation plots/RelValTTbar_14TeV/CMSSW_11_0_0_patch1-PU_110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
Throughput plots/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53
logs and
|
Validation summaryReference release CMSSW_11_1_0_pre8 at 442ae07 Validation plots/RelValTTbar_14TeV/CMSSW_11_0_0_patch1-PU_110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
Throughput plots/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53
logs and
|
|
OK, so
|
Validation summaryReference release CMSSW_11_1_0_pre8 at 442ae07 Validation plots/RelValTTbar_14TeV/CMSSW_11_0_0_patch1-PU_110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
Throughput plots/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53
logs and
|
Validation summaryReference release CMSSW_11_1_0_pre8 at 442ae07 Validation plots/RelValTTbar_14TeV/CMSSW_11_0_0_patch1-PU_110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_0_0_patch1-110X_mcRun3_2021_realistic_v6-v1/GEN-SIM-DIGI-RAW
Throughput plots/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53
logs and
|
|
All |
fwyzard
pushed a commit
that referenced
this pull request
Oct 7, 2020
EcalLinearCorrectionsGPU: - add missing cudaFree() EcalRecHitBuilderKernels: - fix warnings due to unused variables - fix incorrectly skipping some channels due to the use of "return" in the kernel loop - add default values for dead/invalid channels
fwyzard
pushed a commit
that referenced
this pull request
Oct 8, 2020
EcalLinearCorrectionsGPU: - add missing cudaFree() EcalRecHitBuilderKernels: - fix warnings due to unused variables - fix incorrectly skipping some channels due to the use of "return" in the kernel loop - add default values for dead/invalid channels
fwyzard
pushed a commit
that referenced
this pull request
Oct 8, 2020
EcalLinearCorrectionsGPU: - add missing cudaFree() EcalRecHitBuilderKernels: - fix warnings due to unused variables - fix incorrectly skipping some channels due to the use of "return" in the kernel loop - add default values for dead/invalid channels
fwyzard
pushed a commit
that referenced
this pull request
Nov 9, 2020
EcalLinearCorrectionsGPU: - add missing cudaFree() EcalRecHitBuilderKernels: - fix warnings due to unused variables - fix incorrectly skipping some channels due to the use of "return" in the kernel loop - add default values for dead/invalid channels
fwyzard
pushed a commit
that referenced
this pull request
Nov 12, 2020
EcalLinearCorrectionsGPU: - add missing cudaFree() EcalRecHitBuilderKernels: - fix warnings due to unused variables - fix incorrectly skipping some channels due to the use of "return" in the kernel loop - add default values for dead/invalid channels
fwyzard
pushed a commit
that referenced
this pull request
Nov 16, 2020
EcalLinearCorrectionsGPU: - add missing cudaFree() EcalRecHitBuilderKernels: - fix warnings due to unused variables - fix incorrectly skipping some channels due to the use of "return" in the kernel loop - add default values for dead/invalid channels
fwyzard
added a commit
that referenced
this pull request
Nov 26, 2020
EcalLinearCorrectionsGPU: - add missing cudaFree() EcalRecHitBuilderKernels: - fix warnings due to unused variables - fix incorrectly skipping some channels due to the use of "return" in the kernel loop - add default values for dead/invalid channels
fwyzard
pushed a commit
that referenced
this pull request
Dec 25, 2020
EcalLinearCorrectionsGPU: - add missing cudaFree() EcalRecHitBuilderKernels: - fix warnings due to unused variables - fix incorrectly skipping some channels due to the use of "return" in the kernel loop - add default values for dead/invalid channels
fwyzard
pushed a commit
that referenced
this pull request
Dec 29, 2020
EcalLinearCorrectionsGPU: - add missing cudaFree() EcalRecHitBuilderKernels: - fix warnings due to unused variables - fix incorrectly skipping some channels due to the use of "return" in the kernel loop - add default values for dead/invalid channels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR: #462
Some comments from: #473